netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nft] src: add netdev family support
Date: Tue, 26 May 2015 19:17:47 +0200	[thread overview]
Message-ID: <20150526171747.GA5758@salvia> (raw)
In-Reply-To: <20150526165204.GA13360@acer.localdomain>

On Tue, May 26, 2015 at 06:52:04PM +0200, Patrick McHardy wrote:
> On 25.05, Pablo Neira Ayuso wrote:
> > diff --git a/include/rule.h b/include/rule.h
> > index 97959f7..06ec2ff 100644
> > --- a/include/rule.h
> > +++ b/include/rule.h
> > @@ -72,6 +72,7 @@ enum table_flags {
> >   *
> >   * @list:	list node
> >   * @handle:	table handle
> > + * @dev:	network device name (only for netdev family)
> >   * @location:	location the table was defined at
> >   * @chains:	chains contained in the table
> >   * @sets:	sets contained in the table
> > @@ -80,6 +81,7 @@ enum table_flags {
> >  struct table {
> >  	struct list_head	list;
> >  	struct handle		handle;
> > +	const char		*dev;
> 
> I think this logically belongs into struct handle itself.

Thanks Patrick, I'll move this to the handle.

      reply	other threads:[~2015-05-26 17:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 12:46 [PATCH 0/3 nf-next] nf_tables support at ingress Pablo Neira Ayuso
2015-05-25 12:46 ` [PATCH 1/3 nf-next] netfilter: default CONFIG_NETFILTER_INGRESS to y Pablo Neira Ayuso
2015-05-26  0:44   ` Simon Horman
2015-05-26  9:41     ` Pablo Neira Ayuso
2015-05-25 12:46 ` [PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device Pablo Neira Ayuso
2015-05-26  0:48   ` Simon Horman
2015-05-26  9:58     ` Pablo Neira Ayuso
2015-05-27  1:08       ` Simon Horman
2015-05-25 12:46 ` [PATCH 3/3 nf-next] netfilter: nf_tables: add netdev table to filter from ingress Pablo Neira Ayuso
2015-05-25 12:46 ` [PATCH libnftnl] table: add netdev family support Pablo Neira Ayuso
2015-05-25 12:46 ` [PATCH nft] src: " Pablo Neira Ayuso
2015-05-26 16:52   ` Patrick McHardy
2015-05-26 17:17     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526171747.GA5758@salvia \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).