From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Wensong Zhang <wensong@linux-vs.org>,
Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipvs: prevent some underflows
Date: Thu, 11 Jun 2015 09:57:34 -0300 [thread overview]
Message-ID: <20150611125734.GL4049@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.11.1506110811030.1827@ja.home.ssi.bg>
Hi,
On Thu, Jun 11, 2015 at 08:18:06AM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 9 Jun 2015, Marcelo Ricardo Leitner wrote:
>
> > On Mon, Jun 08, 2015 at 10:16:23PM +0300, Julian Anastasov wrote:
> > >
> > > May be we should use min(dev->mtu, 1500) instead of
> > > dev->mtu to avoid sending too large packets for the common
> > > case.
> >
> > That will put an upper limit on it, no? If the load balancers share a
> > big MTU, why not use it?
>
> Yes, without any configuration (eg. sysctl value),
> such defaults should reduce the chance for incompatibilities.
> I.e. we should not send more than 1500 and should be able to
> receive at least 1500.
I'm not sure we should anticipate bad networking setups like that.
Probably ipvs wouldn't be the only one to suffer from such bad config.
Anyway, then we should include that sysctl together with that min(),
because otherwise it will be impossible to send packets larger than
1500 and this may be a regression to some users. Or maybe you don't
think that large packets are worth for the sync at all?
Thanks,
Marcelo
next prev parent reply other threads:[~2015-06-11 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 9:33 [patch] ipvs: prevent some underflows Dan Carpenter
2015-06-08 19:16 ` Julian Anastasov
2015-06-09 12:26 ` Marcelo Ricardo Leitner
2015-06-11 5:18 ` Julian Anastasov
2015-06-11 12:57 ` Marcelo Ricardo Leitner [this message]
2015-06-11 13:17 ` Dan Carpenter
2015-06-16 19:28 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611125734.GL4049@localhost.localdomain \
--to=mleitner@redhat.com \
--cc=coreteam@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).