From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 nf-next 2/2] netfilter: xtables: avoid percpu ruleset duplication
Date: Fri, 12 Jun 2015 14:32:52 +0200 [thread overview]
Message-ID: <20150612123252.GA13866@salvia> (raw)
In-Reply-To: <1434000773.27504.31.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Jun 10, 2015 at 10:32:53PM -0700, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 01:34 +0200, Florian Westphal wrote:
> > We store the rule blob per (possible) cpu. Unfortunately this means we can
> > waste lot of memory on big smp machines. ipt_entry structure ('rule head')
> > is 112 byte, so e.g. with maxcpu=64 one single rule eats
> > close to 8k RAM.
> >
> > Since previous patch made counters percpu it appears there is nothing
> > left in the rule blob that needs to be percpu.
> >
> > On my test system (144 possible cpus, 400k dummy rules) this
> > change saves close to 9 Gigabyte of RAM.
> >
> > Reported-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> > Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> > ---
>
> Very happy to see this happening, thanks Florian.
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied this series, thanks !
next prev parent reply other threads:[~2015-06-12 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 23:34 [PATCH v3 nf-next 1/2] netfilter: xtables: use percpu rule counters Florian Westphal
2015-06-10 23:34 ` [PATCH v3 nf-next 2/2] netfilter: xtables: avoid percpu ruleset duplication Florian Westphal
2015-06-11 5:32 ` Eric Dumazet
2015-06-12 12:32 ` Pablo Neira Ayuso [this message]
2015-06-12 15:04 ` Eric Dumazet
2015-06-11 5:32 ` [PATCH v3 nf-next 1/2] netfilter: xtables: use percpu rule counters Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612123252.GA13866@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).