From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next] x_tables: remove XT_TABLE_INFO_SZ and a dereference.
Date: Mon, 15 Jun 2015 23:01:21 +0200 [thread overview]
Message-ID: <20150615210121.GA3458@salvia> (raw)
In-Reply-To: <1434387450.27504.139.camel@edumazet-glaptop2.roam.corp.google.com>
On Mon, Jun 15, 2015 at 09:57:30AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> After Florian patches, there is no need for XT_TABLE_INFO_SZ anymore :
> Only one copy of table is kept, instead of one copy per cpu.
>
> We also can avoid a dereference if we put table data right after
> xt_table_info. It reduces register pressure and helps compiler.
>
> Then, we attempt a kmalloc() if total size is under order-3 allocation,
> to reduce TLB pressure, as in many cases, rules fit in 32 KB.
Applied, thanks a lot Eric.
prev parent reply other threads:[~2015-06-15 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 16:57 [PATCH nf-next] x_tables: remove XT_TABLE_INFO_SZ and a dereference Eric Dumazet
2015-06-15 21:01 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615210121.GA3458@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).