From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Miroslav Kratochvil <exa.exa@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] parser_bison: allow to use mark as datatype for maps and sets
Date: Wed, 17 Jun 2015 12:33:03 +0200 [thread overview]
Message-ID: <20150617103303.GA3365@salvia> (raw)
In-Reply-To: <CAO0uZ+-k7FVjpforphDBLEnLEpxMj8uSnQWOTeFvVzSRonWpUg@mail.gmail.com>
On Wed, Jun 17, 2015 at 10:29:30AM +0200, Miroslav Kratochvil wrote:
> > > Yes, I think this is preferrable since the mark type can be used for
> > > things besides packet marking, f.i. conntracks.
> >
> > Ok, then I'll push this patch, thanks!
>
>
> Great, marking by named map is now perfectly usuable.
>
> One last (cosmetic reminder) thing, could the last occurence of
> "packetmark" type name in documentation also be replaced with "mark",
> for consistency?
>
> in doc/nft.xml, lines 988, 1887.
Would you send us a Signed-off-by patch that I can apply via git am?
Thanks.
prev parent reply other threads:[~2015-06-17 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 15:52 [PATCH nft] parser_bison: allow to use mark as datatype for maps and sets Pablo Neira Ayuso
2015-06-16 15:49 ` Patrick McHardy
2015-06-16 15:57 ` Pablo Neira Ayuso
2015-06-17 8:29 ` Miroslav Kratochvil
2015-06-17 10:33 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617103303.GA3365@salvia \
--to=pablo@netfilter.org \
--cc=exa.exa@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).