From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH nft 3/3] rule: fix use of intervals in set declarations Date: Fri, 19 Jun 2015 15:44:44 +0200 Message-ID: <20150619134444.GL22946@acer.localdomain> References: <1434719718-10371-1-git-send-email-pablo@netfilter.org> <1434719718-10371-3-git-send-email-pablo@netfilter.org> <20150619131336.GH22946@acer.localdomain> <20150619134816.GA19433@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, admin@rollinix.net, niels@kristensen.io, tom@compton.nu To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:56676 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbbFSNor (ORCPT ); Fri, 19 Jun 2015 09:44:47 -0400 Content-Disposition: inline In-Reply-To: <20150619134816.GA19433@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 19.06, Pablo Neira Ayuso wrote: > On Fri, Jun 19, 2015 at 03:13:36PM +0200, Patrick McHardy wrote: > > > static int do_add_setelems(struct netlink_ctx *ctx, const struct handle *h, > > > - const struct expr *expr) > > > + const struct location *loc, struct expr *expr) > > > { > > > - if (netlink_add_setelems(ctx, h, expr) < 0) > > > + struct set *set; > > > + > > > + if (netlink_get_set(ctx, h, loc) < 0) > > > > I think we should get it from the internal list and not from the > > kernel. > > There is no such internal list at this moment, we retrieve the list > only for do_command_list(). Are you suggesting to add the code to > retrieve it inconditionally initially? We do have the table->sets list. Yeah, but we don't add it to that list in the creation part, I see. Actually we should be doing that, since otherwise we also won't support creating a set and adding new elements in seperate commands but a single transaction. > > We can't add intervals to existing sets so far anyways, and this > > would allow it, but it wouldn't work. > > Not sure what you mean with this. Intervals need to know the entire set content to be created correctly. We don't handle incremental updates with intervals correctly ATM. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in