From: Florian Westphal <fw@strlen.de>
To: Alexander Petrenas <zeracles@zeracles.net.ru>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: Kernel 4.1.0 broke the TARPIT & DELUGE targets in xtables-addons-2.6
Date: Tue, 23 Jun 2015 11:39:47 +0200 [thread overview]
Message-ID: <20150623093947.GA2324@breakpoint.cc> (raw)
In-Reply-To: <52756b9a-0699-405b-918c-73bcfafe97bb@zeracles.net.ru>
Alexander Petrenas <zeracles@zeracles.net.ru> wrote:
> Netfilter changes in the recent 4.1.0 kernel update included removal of the BRNF_BRIDGED flag:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=40451fd013878b005ccae767dfebc07dfecf85d9
>
> Unfortunately, getting rid of BRNF_BRIDGED flag broke the xtables-addons-2.6 package, which now fails to build TARPIT & DELUGE targets with the following errors:
>
> xtables-addons-2.6/extensions/xt_TARPIT.c:253:30: error: ‘BRNF_BRIDGED’ undeclared (first use in this function)
> nskb->nf_bridge->mask & BRNF_BRIDGED))
> ^
>
> xtables-addons-2.6/extensions/xt_TARPIT.c:282:2: error: too few arguments to function ‘NF_HOOK’
> NF_HOOK(NFPROTO_IPV4, NF_INET_LOCAL_OUT, nskb, NULL,
> ^
NF_HOOK(NFPROTO_IPV4, NF_INET_LOCAL_OUT, NULL, nskb, NULL,
> xtables-addons-2.6/extensions/xt_TARPIT.c:397:2: error: too few arguments to function ‘NF_HOOK’
> NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, nskb, NULL,
same
> My kernel hacking skills are non-existant (as well as my C skills), so I expectedly failed to come up with any patch that would replace BRNF_BRIDGED flag with nf_bridge->physoutdev in the following xt_TARPIT.c code:
>
> #ifdef CONFIG_BRIDGE_NETFILTER
> if (hook != NF_INET_FORWARD || (nskb->nf_bridge != NULL &&
> nskb->nf_bridge->mask & BRNF_BRIDGED))
> #else
if (hook != NF_INET_FORWARD || (nskb->nf_bridge != NULL &&
nskb->nf_bridge->physoutdev))
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-23 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 21:40 Kernel 4.1.0 broke the TARPIT & DELUGE targets in xtables-addons-2.6 Alexander Petrenas
2015-06-23 9:39 ` Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-23 10:44 Alexander Petrenas
2015-06-23 11:17 ` Alexander Petrenas
2015-07-06 3:45 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623093947.GA2324@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=zeracles@zeracles.net.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).