From: Florian Westphal <fw@strlen.de>
To: pfeiffer.szilard@balabit.hu
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] conntrack: made the protocol option value case insensitive
Date: Fri, 26 Jun 2015 09:19:21 +0200 [thread overview]
Message-ID: <20150626071921.GA30656@breakpoint.cc> (raw)
In-Reply-To: <1435227145-15554-1-git-send-email-pfeiffer.szilard@balabit.hu>
pfeiffer.szilard@balabit.hu <pfeiffer.szilard@balabit.hu> wrote:
> From: Szilárd Pfeiffer <pfeiffer.szilard@balabit.hu>
>
> Extensions register protocols by lowercase protocol name, but value of
> proto command line option may be uppercase. Extension related options
> cannot be used when protocol name comparision fails.
>
> Signed-off-by: Szilárd Pfeiffer <pfeiffer.szilard@balabit.hu>
> ---
> src/conntrack.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/conntrack.c b/src/conntrack.c
> index f7d37fb..b1a2589 100644
> --- a/src/conntrack.c
> +++ b/src/conntrack.c
> @@ -555,6 +555,12 @@ static struct ctproto_handler *findproto(char *name, int *pnum)
> /* using the protocol name for an unsupported protocol? */
> if ((pent = getprotobyname(name))) {
> *pnum = pent->p_proto;
Why not use strcasecmp to check the proto_list?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-26 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 10:12 [PATCH] conntrack: made the protocol option value case insensitive pfeiffer.szilard
2015-06-26 7:19 ` Florian Westphal [this message]
2015-07-02 16:59 ` Pablo Neira Ayuso
2015-07-02 22:53 ` Szilárd Pfeiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626071921.GA30656@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pfeiffer.szilard@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).