From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@regit.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables 1/3] erec: fix buffer overflow
Date: Tue, 30 Jun 2015 02:03:00 +0200 [thread overview]
Message-ID: <20150630000245.GA6449@salvia> (raw)
In-Reply-To: <1435132311-31452-2-git-send-email-eric@regit.org>
On Wed, Jun 24, 2015 at 09:51:49AM +0200, Eric Leblond wrote:
> A static array was used to read data and to write information in
> it without checking the limit of the array. The result was a buffer
> overflow when the line was longer than 1024.
>
> This patch now uses a allocated buffer to avoid the problem.
Applied, thanks Eric.
I have replaced malloc and free by xmalloc and xfree respectively.
next prev parent reply other threads:[~2015-06-29 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 7:51 [nftables 0/3] misc fixes Eric Leblond
2015-06-24 7:51 ` [nftables 1/3] erec: fix buffer overflow Eric Leblond
2015-06-30 0:03 ` Pablo Neira Ayuso [this message]
2015-06-24 7:51 ` [nftables 2/3] erec: fix logic when reading from file Eric Leblond
2015-06-30 0:03 ` Pablo Neira Ayuso
2015-06-24 7:51 ` [nftables 3/3] mnl: improve select timeout logic Eric Leblond
2015-06-24 9:31 ` Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630000245.GA6449@salvia \
--to=pablo@netfilter.org \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).