netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: vzdevel <devel@openvz.org>, Pavel Emelyanov <xemul@virtuozzo.com>,
	Konstantin Khorenko <khorenko@virtuozzo.com>,
	Jan Engelhardt <jengelh@medozas.de>
Subject: [Q] iptables AH module api mismatch between -master and 1.4.7
Date: Wed, 15 Jul 2015 15:15:22 +0300	[thread overview]
Message-ID: <20150715121521.GK2034@uranus> (raw)

Hello! Could you clarify please the following aspect: before the commit

 | commit 6944f2c8190f1c4319aeac748470c71b0ba45025
 | Author: Jan Engelhardt <jengelh@medozas.de>
 | Date:   Tue May 24 23:50:29 2011 +0200
 |
 |    libxtables: have xtopt_parse_mint interpret partially-spec'd ranges
 |
 |    When ":n" or "n:" is specified, it will now be interpreted as "0:n"
 |    and "n:<max>", respecitvely. nvals will always reflect the number of
 |    (expanded) components. This restores the functionality of options that
 |    take such partially-unspecified ranges.
 |
 |    This makes it possible to nuke the per-matchdata init functions of
 |    some extensions and simply the extensions postparsing to the point
 |    where it only needs to check for nvals==1 or ==2.
 |
 |    Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

if the AH module has no --ahspi argument passed to iptables then it
became [0;0xffffffff] by default, but in -master branch it becomes
[0;0] instead, which implies that if iptables-save is called with
latest -master branch it should not be used with old (1.4.7)
iptables-restore otherwise the kernel would see different --ahspi
ranges. Thus (if only I'm not missing something obvious) this is
abi breakage and old behaviour should be fixed (I'm gonna prepare
a patch for that but would love to know first if it's needed)?

	Cyrill

             reply	other threads:[~2015-07-15 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 12:15 Cyrill Gorcunov [this message]
2015-07-15 13:10 ` [Q] iptables AH module api mismatch between -master and 1.4.7 Jan Engelhardt
2015-07-15 13:19   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150715121521.GK2034@uranus \
    --to=gorcunov@gmail.com \
    --cc=devel@openvz.org \
    --cc=jengelh@medozas.de \
    --cc=khorenko@virtuozzo.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).