From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put" Date: Wed, 15 Jul 2015 19:00:00 +0200 Message-ID: <20150715170000.GA4304@salvia> References: <1436510569-10752-1-git-send-email-horms@verge.net.au> <1436510569-10752-2-git-send-email-horms@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Wensong Zhang , Julian Anastasov , Markus Elfring To: Simon Horman Return-path: Received: from mail.us.es ([193.147.175.20]:51696 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbbGOQyR (ORCPT ); Wed, 15 Jul 2015 12:54:17 -0400 Content-Disposition: inline In-Reply-To: <1436510569-10752-2-git-send-email-horms@verge.net.au> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Jul 10, 2015 at 03:42:49PM +0900, Simon Horman wrote: > From: Markus Elfring > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Signed-off-by: Simon Horman Applied, thanks Simon.