From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH -next v2 0/6] netfilter: xtables: improve jumpstack handling
Date: Wed, 15 Jul 2015 20:52:24 +0200 [thread overview]
Message-ID: <20150715185224.GJ25674@breakpoint.cc> (raw)
In-Reply-To: <20150715171749.GA4707@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> If we take this patch into the tree, I'd wait for quite some time to
> make sure nobody barfs to us with problems, so we can revert it.
>
> Otherwise, the (unlikely) scenario would require several reverts in a
> row, starting from this to further suggested enhancements, right?
Yes, thats exactly the problem.
So for example if we'd switch to allocating the jumpstack in the percpu
area (rather than just a pointer as we do now) we would need to revert
that since percpu allocations have sie limitations (64k max iirc).
HOWEVER, the real problem is -- if you apply this, how long would
you propose to wait before we would leverage the limitation in further
patches?
I'd say 3 years minimum, and I'd rather see nft ready by then :)
So I'd say drop patch 6.
prev parent reply other threads:[~2015-07-15 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 15:51 [PATCH -next v2 0/6] netfilter: xtables: improve jumpstack handling Florian Westphal
2015-07-14 15:51 ` [PATCH -next v2 1/6] netfilter: xtables: compute exact size needed for jumpstack Florian Westphal
2015-07-14 15:51 ` [PATCH -next v2 2/6] netfilter: move tee_active to core Florian Westphal
2015-07-14 15:51 ` [PATCH -next v2 3/6] netfilter: xtables: don't save/restore jumpstack offset Florian Westphal
2015-07-14 15:51 ` [PATCH -next 4/6] netfilter: add and use jump label for xt_tee Florian Westphal
2015-07-14 15:51 ` [PATCH -next 5/6] netfilter: xtables: remove __pure annotation Florian Westphal
2015-07-14 15:51 ` [PATCH -next v2 6/6] netfilter: xtables: add upper limit on call chain depth Florian Westphal
2015-07-15 17:17 ` [PATCH -next v2 0/6] netfilter: xtables: improve jumpstack handling Pablo Neira Ayuso
2015-07-15 18:52 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715185224.GJ25674@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).