netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andreas Herz <andi@geekosphere.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] fix wrong headername in ipv6header for protocols
Date: Mon, 20 Jul 2015 09:21:26 +0200	[thread overview]
Message-ID: <20150720072126.GA4136@salvia> (raw)
In-Reply-To: <1437054859-15824-1-git-send-email-andi@geekosphere.org>

On Thu, Jul 16, 2015 at 03:54:19PM +0200, Andreas Herz wrote:
> In the --help output and manpage for ipv6header the name for upper layer
> protocol headers was "proto", while in the code itself it's "prot" for
> the short form. Fixed by changing manpage and help output.
> 
> Signed-off-by: Andreas Herz <andi@geekosphere.org>
> ---
>  extensions/libip6t_ipv6header.c   | 2 +-
>  extensions/libip6t_ipv6header.man | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/extensions/libip6t_ipv6header.c b/extensions/libip6t_ipv6header.c
> index 00d5d5b..6f03087 100644
> --- a/extensions/libip6t_ipv6header.c
> +++ b/extensions/libip6t_ipv6header.c
> @@ -127,7 +127,7 @@ static void ipv6header_help(void)
>  	printf(
>  "ipv6header match options:\n"
>  "[!] --header headers     Type of header to match, by name\n"
> -"                         names: hop,dst,route,frag,auth,esp,none,proto\n"
> +"                         names: hop,dst,route,frag,auth,esp,none,prot\n"
>  "                    long names: hop-by-hop,ipv6-opts,ipv6-route,\n"
>  "                                ipv6-frag,ah,esp,ipv6-nonxt,protocol\n"
>  "                       numbers: 0,60,43,44,51,50,59\n"

I can read this from the code:

static const struct pprot chain_protos[] = {
        { "protocol", IPPROTO_RAW },
...
        { "prot", IPPROTO_RAW },

Could you clarify what you're seeing there? Thanks.

  reply	other threads:[~2015-07-20  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 13:54 [PATCH iptables] fix wrong headername in ipv6header for protocols Andreas Herz
2015-07-20  7:21 ` Pablo Neira Ayuso [this message]
2015-07-20 14:29   ` Andreas Herz
2015-07-20 15:42     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150720072126.GA4136@salvia \
    --to=pablo@netfilter.org \
    --cc=andi@geekosphere.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).