From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: validate generated netlink instructions
Date: Mon, 20 Jul 2015 17:10:46 +0200 [thread overview]
Message-ID: <20150720151046.GD11985@breakpoint.cc> (raw)
In-Reply-To: <20150720125004.GA7402@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Fri, Jul 17, 2015 at 03:31:39AM +0200, Florian Westphal wrote:
> > Don't apply -- this patch is intentionally incomplete;
> > I don't want to spam this list with 350k patch.
> >
> > If you think this is worthwile to have in nft I'll push the full
> > changeset (this patch + 64 test files with recorded netlink debug output).
>
> I like the idea of having more regression tests.
>
> We can probably kill the old .t files and move the 'regression' to
> 'tests'.
Do you mean:
rm tests/*; mv tests/regression/* tests/ ?
Otherwise I'm inclined to just push what I have and let you wrangle
things further if needed :-)
next prev parent reply other threads:[~2015-07-20 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 1:31 [PATCH nft] tests: validate generated netlink instructions Florian Westphal
2015-07-20 12:50 ` Pablo Neira Ayuso
2015-07-20 15:10 ` Florian Westphal [this message]
2015-07-20 15:27 ` Pablo Neira Ayuso
2015-07-20 17:05 ` Pablo Neira Ayuso
2015-07-20 18:35 ` Florian Westphal
2015-08-12 17:34 ` Pablo Neira Ayuso
2015-08-12 17:46 ` Florian Westphal
2015-08-13 9:53 ` Pablo Neira Ayuso
2015-08-13 14:45 ` Florian Westphal
2015-08-16 18:14 ` Patrick McHardy
2015-08-16 18:20 ` Florian Westphal
2015-08-16 18:30 ` Patrick McHardy
2015-08-19 0:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720151046.GD11985@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).