From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH nft] tests: validate generated netlink instructions Date: Mon, 20 Jul 2015 17:10:46 +0200 Message-ID: <20150720151046.GD11985@breakpoint.cc> References: <1437096699-8832-1-git-send-email-fw@strlen.de> <20150720125004.GA7402@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:34767 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932865AbbGTPKr (ORCPT ); Mon, 20 Jul 2015 11:10:47 -0400 Content-Disposition: inline In-Reply-To: <20150720125004.GA7402@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > On Fri, Jul 17, 2015 at 03:31:39AM +0200, Florian Westphal wrote: > > Don't apply -- this patch is intentionally incomplete; > > I don't want to spam this list with 350k patch. > > > > If you think this is worthwile to have in nft I'll push the full > > changeset (this patch + 64 test files with recorded netlink debug output). > > I like the idea of having more regression tests. > > We can probably kill the old .t files and move the 'regression' to > 'tests'. Do you mean: rm tests/*; mv tests/regression/* tests/ ? Otherwise I'm inclined to just push what I have and let you wrangle things further if needed :-)