netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andreas Herz <andi@geekosphere.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] fix wrong headername in ipv6header for protocols
Date: Mon, 20 Jul 2015 17:42:12 +0200	[thread overview]
Message-ID: <20150720154212.GA19471@salvia> (raw)
In-Reply-To: <20150720142934.GA21348@kvmbude>

On Mon, Jul 20, 2015 at 04:29:34PM +0200, Andreas Herz wrote:
> On 20/07/15 at 09:21, Pablo Neira Ayuso wrote:
[...]
> > I can read this from the code:
> > 
> > static const struct pprot chain_protos[] = {
> >         { "protocol", IPPROTO_RAW },
> > ...
> >         { "prot", IPPROTO_RAW },
> > 
> > Could you clarify what you're seeing there? Thanks.
> 
> It's exactly the issue :) as you can see "protocol" and "prot" (without
> _o_ at the end) but the manpage and the help from iptables say
> "protocol" and "proto" (with _o_ at the end).

I see, thanks for explaining. Applied.


      reply	other threads:[~2015-07-20 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 13:54 [PATCH iptables] fix wrong headername in ipv6header for protocols Andreas Herz
2015-07-20  7:21 ` Pablo Neira Ayuso
2015-07-20 14:29   ` Andreas Herz
2015-07-20 15:42     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150720154212.GA19471@salvia \
    --to=pablo@netfilter.org \
    --cc=andi@geekosphere.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).