From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nft] tests: validate generated netlink instructions
Date: Mon, 20 Jul 2015 20:35:36 +0200
Message-ID: <20150720183536.GE11985@breakpoint.cc>
References: <1437096699-8832-1-git-send-email-fw@strlen.de>
 <20150720125004.GA7402@salvia>
 <20150720151046.GD11985@breakpoint.cc>
 <20150720170538.GA22735@salvia>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:35140 "EHLO
	Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751721AbbGTSfi (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Mon, 20 Jul 2015 14:35:38 -0400
Content-Disposition: inline
In-Reply-To: <20150720170538.GA22735@salvia>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Mon, Jul 20, 2015 at 05:10:46PM +0200, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Fri, Jul 17, 2015 at 03:31:39AM +0200, Florian Westphal wrote:
> > > > Don't apply -- this patch is intentionally incomplete;
> > > > I don't want to spam this list with 350k patch.
> > > > 
> > > > If you think this is worthwile to have in nft I'll push the full
> > > > changeset (this patch + 64 test files with recorded netlink debug output).
> > > 
> > > I like the idea of having more regression tests.
> > > 
> > > We can probably kill the old .t files and move the 'regression' to
> > > 'tests'.
> > 
> > Do you mean:
> > rm tests/*; mv tests/regression/* tests/ ?
> > 
> > Otherwise I'm inclined to just push what I have and let you wrangle
> > things further if needed :-)
> 
> BTW, I just remembered another bug we've got in the output.
> 
> I think we have to convert to BE the content that is printed from the
> registers, otherwise we'll have different outputs in LE and BE.

Right.  Another solution would be to keep two sets of each payload in
tests/, one for LE and one for BE platforms, and use the correct one
arcording to whatever arch the script runs on.