netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Kyeong Yoo <Kyeong.Yoo@alliedtelesis.co.nz>,
	"netfilter-devel@vger.kernel.org"
	<netfilter-devel@vger.kernel.org>
Subject: Re: New multiple DSCP match by "-m dscp --dscp-multi value,value,..."
Date: Tue, 4 Aug 2015 11:35:10 +0200	[thread overview]
Message-ID: <20150804093510.GA8019@salvia> (raw)
In-Reply-To: <20150804092511.GD20471@breakpoint.cc>

On Tue, Aug 04, 2015 at 11:25:11AM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Aug 03, 2015 at 04:04:46AM +0000, Kyeong Yoo wrote:
> > > I found this is useful for me to match multiple DSCP values in a rule.
> > > 
> > > For example, if you want to handle traffic with a list of DSCP same way, 
> > > instead of using this:
> > > 
> > >   -A FORWARD ...cond1... -m dscp --dscp-class AF11 -j TARGET
> > >   -A FORWARD ...cond1... -m dscp --dscp-class AF21 -j TARGET
> > >   -A FORWARD ...cond1... -m dscp --dscp-class AF31 -j TARGET
> > >   -A FORWARD ...cond2... -m dscp --dscp 10 -j TARGET
> > >   -A FORWARD ...cond2... -m dscp --dscp 20 -j TARGET
> > > 
> > > you can use:
> > > 
> > >   -A FORWARD ...cond1... -m dscp --dscp-multi AF11,AF21,AF31 -j TARGET
> > >   -A FORWARD ...cond2... -m dscp --dscp-multi 10,20 -j TARGET
> > 
> > We support multiple matches in a rule for long time already:
> > 
> >         -A FORWARD ...cond1...  -m dscp --dscp-class AF11 \
> >                                 -m dscp --dscp-class AF21 \
> >                                 -m dscp --dscp-class AF31 \
> 
> Yes, but that won't work since this is foo && bar, not foo || bar.

Oh I see. I don't like this combo updates, we may keep receiving
patches to do the same thing for other matches in iptables.

nftables resolves this problem through dictionaries, please have a
look at that.

      reply	other threads:[~2015-08-04  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  4:04 New multiple DSCP match by "-m dscp --dscp-multi value,value,..." Kyeong Yoo
2015-08-04  9:19 ` Pablo Neira Ayuso
2015-08-04  9:25   ` Florian Westphal
2015-08-04  9:35     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150804093510.GA8019@salvia \
    --to=pablo@netfilter.org \
    --cc=Kyeong.Yoo@alliedtelesis.co.nz \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).