From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: nft: parser problem, can use mark as datatype in sets and maps
Date: Tue, 11 Aug 2015 12:41:26 +0200
Message-ID: <20150811102635.GA3622@salvia>
References: <1027218717.2766569.1439214492178.JavaMail.zimbra@tpip.net>
 <20150810170920.GA3487@salvia>
 <55C9BDFE.9080207@tpip.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netfilter-devel@vger.kernel.org
To: Andreas Schultz <aschultz@tpip.net>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from mail.us.es ([193.147.175.20]:40039 "EHLO mail.us.es"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964961AbbHKKfj (ORCPT <rfc822;netfilter-devel@vger.kernel.org>);
	Tue, 11 Aug 2015 06:35:39 -0400
Content-Disposition: inline
In-Reply-To: <55C9BDFE.9080207@tpip.net>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

On Tue, Aug 11, 2015 at 11:18:54AM +0200, Andreas Schultz wrote:
> On 08/10/2015 07:09 PM, Pablo Neira Ayuso wrote:
> >On Mon, Aug 10, 2015 at 03:48:12PM +0200, Andreas Schultz wrote:
> >>Hi,
> >>
> >>The data type definition for mark and the general idea of the parser
> >>indicate that the following nft statements should work:
> >>
> >>   # nft add map filter MAP1 { type ipv4_addr : mark\; }
> >>   # nft add set filter SET1 { type mark\; }
> >>
> >>However, both fail with a similar error message:
> >>
> >>   <cmdline>:1:40-43: Error: syntax error, unexpected mark, expecting string
> >>   add map filter MAP1 { type ipv4_addr : mark; }
> >>   <cmdline>:1:28-31: Error: syntax error, unexpected mark, expecting string
> >>   add set filter SET1 { type mark; }
> >>
> >>The problem is parser, it expects a string as data type spec, but
> >>mark is already declared as a token.
> >>
> >>I don't have much experience with bison, so does anyone have a quick
> >>work-around for this?
> >
> >This is fixed by 2baf59c ("parser_bison: allow to use mark as datatype
> >for maps and sets").
> 
> Ah, I was using the next-4.2 branch and missed this fix in master,
> sorry for the noise.
> 
> However, the parser problem is solved, but named mark maps are still
> not working:
> 
> anonymous maps work as expected:
> 
>   # nft add rule ip mangle OUTPUT mark set ip saddr map {
> 192.168.0.10 : 0x1 }
> 
> named maps do not:
> 
>   # nft add map mangle CLASS05 "{ type ipv4_addr : mark; }"
>   # nft add element mangle CLASS05 { 192.168.0.10 : 0x1 }
>   # nft add rule ip mangle OUTPUT mark set ip saddr map @CLASS05
>   <cmdline>:1:1-56: Error: Could not process rule: Invalid argument
> 
> Any idea?

This is working fine here with a nf.git tree snapshot.

table ip mangle {
        map CLASS05 {
                type ipv4_addr : mark
                elements = { 192.168.0.10 : 0x00000001}
        }

        chain OUTPUT {
                type route hook output priority 0; policy accept;
                mark set ip saddr map @CLASS05
        }
}

What Linux kernel version are you using? Remember that concatenation
support is there since 4.1.