netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH nft] tests: validate generated netlink instructions
Date: Wed, 12 Aug 2015 19:34:53 +0200	[thread overview]
Message-ID: <20150812173453.GA30926@salvia> (raw)
In-Reply-To: <20150720183536.GE11985@breakpoint.cc>

Hi Florian,

I found a problem in your change to validate the netlink instructions
from the python infrastructure that we have for nft.

The set elements are not always displayed in the same order depending
on the hash seed, so we get bogus warnings in that case.

I think the fix for the test infrastructure will require something a
bit more complicated that a simple string comparison as we'll need to
interpret the set element part.

Probably it would be good to wrap the netlink instruction generation
code under some option until this is resolved, instead of having it
enabled by default.

Let me know if you come up with any better idea. Thanks!

  reply	other threads:[~2015-08-12 17:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  1:31 [PATCH nft] tests: validate generated netlink instructions Florian Westphal
2015-07-20 12:50 ` Pablo Neira Ayuso
2015-07-20 15:10   ` Florian Westphal
2015-07-20 15:27     ` Pablo Neira Ayuso
2015-07-20 17:05     ` Pablo Neira Ayuso
2015-07-20 18:35       ` Florian Westphal
2015-08-12 17:34         ` Pablo Neira Ayuso [this message]
2015-08-12 17:46           ` Florian Westphal
2015-08-13  9:53             ` Pablo Neira Ayuso
2015-08-13 14:45               ` Florian Westphal
2015-08-16 18:14             ` Patrick McHardy
2015-08-16 18:20               ` Florian Westphal
2015-08-16 18:30                 ` Patrick McHardy
2015-08-19  0:49               ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150812173453.GA30926@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).