Re: [PATCH nft] tests: validate generated netlink instructions

[Florian Westphal <fw@strlen.de>]

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> I found a problem in your change to validate the netlink instructions
> from the python infrastructure that we have for nft.
> 
> The set elements are not always displayed in the same order depending
> on the hash seed, so we get bogus warnings in that case.

Did that change recently?
I run the tests quite extensively at the moment and I did not see
failures in the set parts yet.

> I think the fix for the test infrastructure will require something a
> bit more complicated that a simple string comparison as we'll need to
> interpret the set element part.
> 
> Probably it would be good to wrap the netlink instruction generation
> code under some option until this is resolved, instead of having it
> enabled by default.
> 
> Let me know if you come up with any better idea. Thanks!

I'm currently in the process of finalizing a first draft of vlan
matching, i think i have patches ready next week.

This will also make "nft add rule bridge filter input ip version 4"
work since it adds support for sub-byte sized header elements.

I plan to work on the test suite again after I get v1 out (add BE support
so we can also check nft on s390 etc).

I haven't thought about it yet, first plan was to record separate traces
for LE and BE architectures, think thats better than trying to normalize
the endianess in the output (might also mask errors...).

I'll try to figure out a way to cure the set part.

One way would be accomondate the test parser to recognize the set data
and sort those into some common order (doesn't matter as long as both ondisk
and observed output are in the same sort order).

I don't mind if you add a quick patch that disables the payload
comparision for now, we can reenable it later by default once BE + set
works correctly.