From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: validate generated netlink instructions
Date: Wed, 19 Aug 2015 02:49:06 +0200 [thread overview]
Message-ID: <20150819004906.GA19954@salvia> (raw)
In-Reply-To: <20150816181439.GD17659@macbook.localdomain>
On Sun, Aug 16, 2015 at 07:14:40PM +0100, Patrick McHardy wrote:
[...]
> I actually think we should sort it in nft since we might also see duplicate
> netlink messages and should eleminate them from the output since they will
> cause errors on reload.
Right, we need that --sort option so the user always get the same
output when saving the ruleset. The removal of duplicates is also an
issue given the way netlink dumps things.
But the issue with tests is related to --debug=netlink output, so you
suggest we address both sorting and duplication removal from libnftnl, right?
Thanks!
prev parent reply other threads:[~2015-08-19 0:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 1:31 [PATCH nft] tests: validate generated netlink instructions Florian Westphal
2015-07-20 12:50 ` Pablo Neira Ayuso
2015-07-20 15:10 ` Florian Westphal
2015-07-20 15:27 ` Pablo Neira Ayuso
2015-07-20 17:05 ` Pablo Neira Ayuso
2015-07-20 18:35 ` Florian Westphal
2015-08-12 17:34 ` Pablo Neira Ayuso
2015-08-12 17:46 ` Florian Westphal
2015-08-13 9:53 ` Pablo Neira Ayuso
2015-08-13 14:45 ` Florian Westphal
2015-08-16 18:14 ` Patrick McHardy
2015-08-16 18:20 ` Florian Westphal
2015-08-16 18:30 ` Patrick McHardy
2015-08-19 0:49 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819004906.GA19954@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).