Linux Netfilter development
 help / color / mirror / Atom feed
From: Andreas Herz <andi@geekosphere.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: ICMPv6 Type 1 Code 5 and 6 missing in iptables REJECT target and icmpv6 match
Date: Thu, 20 Aug 2015 11:21:26 +0200	[thread overview]
Message-ID: <20150820092126.GS21654@kvmbude> (raw)
In-Reply-To: <alpine.LSU.2.20.1508201112020.8021@nerf40.vanv.qr>

On 20/08/15 at 11:16, Jan Engelhardt wrote:
> 
> On Thursday 2015-08-20 11:06, Andreas Herz wrote:
> >
> >I just tested around and icmpv6 is already working but that's caused by
> >rather optimistic parsing:
> >
> >> if (!xtables_strtoui(slash+1, NULL, &number, 0, UINT8_MAX))
> >
> >So --icmpv6-type 1/255 is also possible.
> 
> Specifying raw numbers for packet fields should always be possible, 
> exactly because some local name mapping database may be out of date or 
> because new things get invented at IETF over time.

Sounds reasonable, so i will just add the names. Thanks for the
explanation. The icmpv6 match was just something i looked into while i
saw the issue with REJECT. So small patch incoming.

> However, since you are concerned about the REJECT target, and 
> --reject-with takes a mnemonic that is only used to communicate with the 
> kernel module, rather than a value that is directly placed into a 
> network packet, the above would not apply.

And i don't even have a chance to "cheat" (as i can with the raw numbers
in the icmpv6 match) so i will work on that part to add those codes.

-- 
Andreas Herz

      reply	other threads:[~2015-08-20  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 14:51 ICMPv6 Type 1 Code 5 and 6 missing in iptables REJECT target and icmpv6 match Andreas Herz
2015-08-20  8:13 ` Jan Engelhardt
2015-08-20  9:06   ` Andreas Herz
2015-08-20  9:16     ` Jan Engelhardt
2015-08-20  9:21       ` Andreas Herz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820092126.GS21654@kvmbude \
    --to=andi@geekosphere.org \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox