netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack
Date: Thu, 20 Aug 2015 13:38:42 +0200	[thread overview]
Message-ID: <20150820113841.3543.68437.stgit@nfdev2.cica.es> (raw)

The nfct program uses none of the symbols of libnetfilter_conntrack.

Linking against it means that distributors have to maintain an useless
depedency.

This was spotted by the dpkg-shlibdeps tool.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/Makefile.am |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 1bc3622..a1d00f8 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -25,7 +25,6 @@ nfct_SOURCES += nfct-extensions/timeout.c
 endif
 
 nfct_LDADD = ${LIBMNL_LIBS} 			\
-	     ${LIBNETFILTER_CONNTRACK_LIBS}	\
 	     ${libdl_LIBS}
 
 if HAVE_CTTIMEOUT


             reply	other threads:[~2015-08-20 12:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 11:38 Arturo Borrero Gonzalez [this message]
2015-08-20 18:30 ` [conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack Jan Engelhardt
2015-08-21  6:54   ` Arturo Borrero Gonzalez
2015-08-26 18:46     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820113841.3543.68437.stgit@nfdev2.cica.es \
    --to=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).