[conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack

[conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack

[Arturo Borrero Gonzalez]

The nfct program uses none of the symbols of libnetfilter_conntrack.

Linking against it means that distributors have to maintain an useless
depedency.

This was spotted by the dpkg-shlibdeps tool.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/Makefile.am |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 1bc3622..a1d00f8 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -25,7 +25,6 @@ nfct_SOURCES += nfct-extensions/timeout.c
 endif
 
 nfct_LDADD = ${LIBMNL_LIBS} 			\
-	     ${LIBNETFILTER_CONNTRACK_LIBS}	\
 	     ${libdl_LIBS}
 
 if HAVE_CTTIMEOUT

Re: [conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack

[Jan Engelhardt]

On Thursday 2015-08-20 13:38, Arturo Borrero Gonzalez wrote:

>The nfct program uses none of the symbols of libnetfilter_conntrack.
>
>Linking against it means that distributors have to maintain an useless
>depedency.

Not to say the patch is bad, but:
Distributions do not really have to maintain a dependency anyway, 
as it can be autodiscovered from the DT_NEEDED entries. In addition,
conntrackd still uses the library, so a dependency in the package
will stay around.

Re: [conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack

[Arturo Borrero Gonzalez]

On 20 August 2015 at 20:30, Jan Engelhardt <jengelh@inai.de> wrote:
> On Thursday 2015-08-20 13:38, Arturo Borrero Gonzalez wrote:
>
>>The nfct program uses none of the symbols of libnetfilter_conntrack.
>>
>>Linking against it means that distributors have to maintain an useless
>>depedency.
>
> Not to say the patch is bad, but:
> Distributions do not really have to maintain a dependency anyway,
> as it can be autodiscovered from the DT_NEEDED entries. In addition,
> conntrackd still uses the library, so a dependency in the package
> will stay around.

In case of debian, there are 3 different binary packages for
conntrack, conntrackd and nfct. Each package may have different
dependencies.
-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [conntrack-tools PATCH] nfct: don't link against libnetfilter_conntrack

[Pablo Neira Ayuso]

On Fri, Aug 21, 2015 at 08:54:00AM +0200, Arturo Borrero Gonzalez wrote:
> On 20 August 2015 at 20:30, Jan Engelhardt <jengelh@inai.de> wrote:
> > On Thursday 2015-08-20 13:38, Arturo Borrero Gonzalez wrote:
> >
> >>The nfct program uses none of the symbols of libnetfilter_conntrack.
> >>
> >>Linking against it means that distributors have to maintain an useless
> >>depedency.
> >
> > Not to say the patch is bad, but:
> > Distributions do not really have to maintain a dependency anyway,
> > as it can be autodiscovered from the DT_NEEDED entries. In addition,
> > conntrackd still uses the library, so a dependency in the package
> > will stay around.
> 
> In case of debian, there are 3 different binary packages for
> conntrack, conntrackd and nfct. Each package may have different
> dependencies.

Also applied, thanks Arturo.