From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Elad Raz <eladr@mellanox.com>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
netfilter-devel@vger.kernel.org,
Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>,
Vinson Lee <vlee@twopensource.com>, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Sergey Popovich <popovich_sergei@mail.ua>,
Anton Danilov <littlesmilingcloud@gmail.com>,
Guenter Roeck <linux@roeck-us.net>, Akemi Yagi <amyagi@gmail.com>,
Cong Wang <cwang@twopensource.com>
Subject: Re: [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union init
Date: Sat, 22 Aug 2015 20:44:48 +0200 [thread overview]
Message-ID: <20150822184448.GA3610@salvia> (raw)
In-Reply-To: <alpine.DEB.2.10.1508222006570.13403@blackhole.kfki.hu>
Cc'ing Andrew, since he's got a similar patch in mmotm [1].
On Sat, Aug 22, 2015 at 08:11:18PM +0200, Jozsef Kadlecsik wrote:
> On Sat, 22 Aug 2015, Elad Raz wrote:
>
> > In continue to proposed Vinson Lee's post [1], this patch fixes compilation
> > issues founded at gcc 4.4.7. The initialization of .cidr field of unnamed
> > unions causes compilation error in gcc 4.4.x.
>
> There's already a (couple of weeks old) patch in the -mm tree to fix the
> gcc compatilibity issue, see the last comment in the thread you refer to:
>
> > Visible links
> > [1] https://lkml.org/lkml/2015/7/5/74
>
> So I'm unsure whether a new patch should be submitted for this.
I'll take this patch so this follows the usual path through David's
net tree. IIRC, duplicates get automatically dropped from the mmotm
tree.
[1] http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/commit/?id=18b386426ff0a90e405c962ec8f51ea70e7df637
I'll wait for some little time just in case someone raises any
concern.
Thanks!
next prev parent reply other threads:[~2015-08-22 18:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 5:44 [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union init Elad Raz
2015-08-22 18:11 ` Jozsef Kadlecsik
2015-08-22 18:21 ` Akemi Yagi
2015-08-22 18:44 ` Pablo Neira Ayuso [this message]
2015-08-28 22:59 ` [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union initg Pablo Neira Ayuso
2015-08-28 23:21 ` Akemi Yagi
2015-08-31 7:16 ` Vinson Lee
2015-09-13 1:01 ` Akemi Yagi
2015-09-13 11:52 ` Pablo Neira Ayuso
2015-10-19 20:51 ` Akemi Yagi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150822184448.GA3610@salvia \
--to=pablo@netfilter.org \
--cc=akpm@linux-foundation.org \
--cc=amyagi@gmail.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux@roeck-us.net \
--cc=littlesmilingcloud@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa \
--cc=popovich_sergei@mail.ua \
--cc=vlee@twopensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).