From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] netfilter: reduce sparse warnings
Date: Sat, 29 Aug 2015 00:37:59 +0200 [thread overview]
Message-ID: <20150828223759.GA3609@salvia> (raw)
In-Reply-To: <1440713781-18260-1-git-send-email-fw@strlen.de>
On Fri, Aug 28, 2015 at 12:16:21AM +0200, Florian Westphal wrote:
> bridge/netfilter/ebtables.c:290:26: warning: incorrect type in assignment (different modifiers)
> -> remove __pure annotation.
>
> ipv6/netfilter/ip6t_SYNPROXY.c:240:27: warning: cast from restricted __be16
> -> switch ntohs to htons and vice versa.
>
> netfilter/core.c:391:30: warning: symbol 'nfq_ct_nat_hook' was not declared. Should it be static?
> -> delete it, got removed
>
> net/netfilter/nf_synproxy_core.c:221:48: warning: cast to restricted __be32
> -> Use __be32 instead of u32.
>
> Tested with objdiff that these changes do not affect generated code.
Also applied, thanks.
prev parent reply other threads:[~2015-08-28 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 22:16 [PATCH -next] netfilter: reduce sparse warnings Florian Westphal
2015-08-28 22:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828223759.GA3609@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).