From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Feng Gao <gfree.wind@gmail.com>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: nf_ct_tcp: Remove the duplicated word in comment
Date: Sat, 29 Aug 2015 01:14:36 +0200 [thread overview]
Message-ID: <20150828231436.GA24569@salvia> (raw)
In-Reply-To: <CA+6hz4o+XCrHt_f31kK1d2=jsHY3mDvU4rEM=8DbmhiVbxDSNw@mail.gmail.com>
On Sat, Aug 22, 2015 at 11:27:56AM +0800, Feng Gao wrote:
> Hi Pablo,
>
> To try to resolve the "git am" issue, so I start the new email
> conversation. The attachment is the latest patch file.
>
> The following is the patch content too.
Still not working, I think your MUA is mangling the patch. I can see
that tabs are converted to spaces.
$ git am /temporary/netfilter-nf_ct_tcp-Remove-the-duplicated-word-in-comment.patch -s
Applying: netfilter: nf_ct_tcp: Remove the duplicated word in comment
error: patch failed: net/netfilter/nf_conntrack_proto_tcp.c:1088
error: net/netfilter/nf_conntrack_proto_tcp.c: patch does not apply
Patch failed at 0001 netfilter: nf_ct_tcp: Remove the duplicated word in comment
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
$ git am --abort
$ patch -p1 < /temporary/netfilter_ct_tcp-Remove-the-duplicated-word-in-comment.patch
patching file net/netfilter/nf_conntrack_proto_tcp.c
Hunk #1 FAILED at 1088.
1 out of 1 hunk FAILED -- saving rejects to file
net/netfilter/nf_conntrack_proto_tcp.c.rej
> - /* Set ASSURED if we see see valid ack in ESTABLISHED
> - after SYN_RECV or a valid answer for a picked up
> - connection. */
> + /* Set ASSURED if we see valid ack in ESTABLISHED after
> + * SYN_RECV or a valid answer for a picked up connection.
> + */
^^^^^^^^
I can see space here instead of tab.
next prev parent reply other threads:[~2015-08-28 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 3:27 [PATCH] netfilter: nf_ct_tcp: Remove the duplicated word in comment Feng Gao
2015-08-28 23:14 ` Pablo Neira Ayuso [this message]
2015-08-31 8:44 ` Feng Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828231436.GA24569@salvia \
--to=pablo@netfilter.org \
--cc=gfree.wind@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).