netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@netronome.com>
To: Joe Stringer <joestringer@nicira.com>
Cc: netdev@vger.kernel.org, pshelar@nicira.com,
	linux-kernel@vger.kernel.org, pablo@netfilter.org,
	fwestpha@redhat.com, hannes@redhat.com, tgraf@suug.ch,
	jpettit@nicira.com, jesse@nicira.com,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCHv6 net-next 00/10] OVS conntrack support
Date: Sat, 29 Aug 2015 08:57:28 +0900	[thread overview]
Message-ID: <20150828235725.GA22045@vergenet.net> (raw)
In-Reply-To: <1440613913-10141-1-git-send-email-joestringer@nicira.com>

On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote:
> The goal of this series is to allow OVS to send packets through the Linux
> kernel connection tracker, and subsequently match on fields populated by
> conntrack. This functionality is enabled through a new
> CONFIG_OPENVSWITCH_CONNTRACK option.
> 
> This version addresses the feedback from v5, primarily checking the behaviour
> is correct with different configurations such as disabling
> CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like
> connlabels.
> 
> The branch below has been updated with the corresponding userspace pieces:
> https://github.com/joestringer/ovs dev/ct_20150818

Hi Joe,

Nice work getting this patchset in order.

I am seeing the following when compiling without NF_CONNTRACK_MARK set.

  CC [M]  net/openvswitch//conntrack.o
net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’:
net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no member named ‘mark’
  key->ct.mark = ct ? ct->mark : 0;
                        ^
net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’:
net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member named ‘mark’
  new_mark = ct_mark | (ct->mark & ~(mask));
                          ^
net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member named ‘mark’
  if (ct->mark != new_mark) {
        ^
net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member named ‘mark’
   ct->mark = new_mark;
     ^
scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o' failed
make[1]: *** [net/openvswitch//conntrack.o] Error 1
Makefile:1386: recipe for target '_module_net/openvswitch/' failed
make: *** [_module_net/openvswitch/] Error 2
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-28 23:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 18:31 [PATCHv6 net-next 00/10] OVS conntrack support Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 01/10] openvswitch: Serialize acts with original netlink len Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 02/10] openvswitch: Move MASKED* macros to datapath.h Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 03/10] ipv6: Export nf_ct_frag6_gather() Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 04/10] dst: Add __skb_dst_copy() variation Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 05/10] openvswitch: Add conntrack action Joe Stringer
2015-08-26 18:55   ` Joe Stringer
2015-08-26 20:40   ` Pravin Shelar
2015-08-26 18:31 ` [PATCHv6 net-next 06/10] openvswitch: Allow matching on conntrack mark Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 07/10] netfilter: Always export nf_connlabels_replace() Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 08/10] netfilter: connlabels: Export setting connlabel length Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 09/10] openvswitch: Allow matching on conntrack label Joe Stringer
2015-08-26 18:31 ` [PATCHv6 net-next 10/10] openvswitch: Allow attaching helpers to ct action Joe Stringer
2015-08-27 18:41 ` [PATCHv6 net-next 00/10] OVS conntrack support David Miller
2015-08-28 23:57 ` Simon Horman [this message]
2015-08-29  2:25   ` Joe Stringer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828235725.GA22045@vergenet.net \
    --to=simon.horman@netronome.com \
    --cc=fwestpha@redhat.com \
    --cc=hannes@redhat.com \
    --cc=jesse@nicira.com \
    --cc=joestringer@nicira.com \
    --cc=jpettit@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=pshelar@nicira.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).