From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Vijay Subramanian <subramanian.vijay@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf 1/1] nft: Fix nlmsg_type in GET operation callbacks
Date: Tue, 1 Sep 2015 18:46:10 +0200 [thread overview]
Message-ID: <20150901164610.GA3434@salvia> (raw)
In-Reply-To: <1440887695-15068-1-git-send-email-subramanian.vijay@gmail.com>
Hi Vijay,
On Sat, Aug 29, 2015 at 03:34:55PM -0700, Vijay Subramanian wrote:
> nf_tables_gettable(), nf_tables_getchain() and nf_tables_getrule()
> send replies with nlmsg_type that correspond to ADD operation
> instead of GET. Set the type correctly.
We always NFT_MSG_NEWTABLE as message type other major netlink
subsystems that I can remember, so that is there for consistency.
Is there any why reason you need this change?
next prev parent reply other threads:[~2015-09-01 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 22:34 [PATCH nf 1/1] nft: Fix nlmsg_type in GET operation callbacks Vijay Subramanian
2015-09-01 16:46 ` Pablo Neira Ayuso [this message]
2015-09-01 18:35 ` Vijay Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901164610.GA3434@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).