From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: pablo@netfilter.org, fw@strlen.de,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_dup{4,6}: fix build error when nf_conntrack disabled
Date: Wed, 02 Sep 2015 16:28:26 -0700 (PDT) [thread overview]
Message-ID: <20150902.162826.1354616827708594425.davem@davemloft.net> (raw)
In-Reply-To: <dc51f50f4680ff2d2a91b9852fe6f44f0f14d2cf.1441219641.git.daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Wed, 2 Sep 2015 20:54:02 +0200
> While testing various Kconfig options on another issue, I found that
> the following one triggers as well on allmodconfig and nf_conntrack
> disabled:
>
> net/ipv4/netfilter/nf_dup_ipv4.c: In function ‘nf_dup_ipv4’:
> net/ipv4/netfilter/nf_dup_ipv4.c:72:20: error: ‘nf_skb_duplicated’ undeclared (first use in this function)
> if (this_cpu_read(nf_skb_duplicated))
> [...]
> net/ipv6/netfilter/nf_dup_ipv6.c: In function ‘nf_dup_ipv6’:
> net/ipv6/netfilter/nf_dup_ipv6.c:66:20: error: ‘nf_skb_duplicated’ undeclared (first use in this function)
> if (this_cpu_read(nf_skb_duplicated))
>
> Fix it by including directly the header where it is defined.
>
> Fixes: bbde9fc1824a ("netfilter: factor out packet duplication for IPv4/IPv6")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
I'll take this directly to simplify things.
Thanks Daniel.
prev parent reply other threads:[~2015-09-02 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 18:54 [PATCH nf-next] netfilter: nf_dup{4,6}: fix build error when nf_conntrack disabled Daniel Borkmann
2015-09-02 23:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902.162826.1354616827708594425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).