From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: "Ville Skyttä" <ville.skytta@iki.fi>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: Spelling fixes
Date: Mon, 7 Sep 2015 20:28:47 +0200 [thread overview]
Message-ID: <20150907182847.GA16494@salvia> (raw)
In-Reply-To: <alpine.LSU.2.20.1509060915240.28331@nerf40.vanv.qr>
On Sun, Sep 06, 2015 at 09:15:51AM +0200, Jan Engelhardt wrote:
>
> On Sunday 2015-09-06 08:22, Ville Skyttä wrote:
> >
> >-/* print a given ip including mask if neccessary */
> >+/* Print a given ip including mask if necessary.
> >+ */
> > static void print_ip(const char *prefix, const struct in6_addr *ip,
> > const struct in6_addr *mask, int invert)
> > {
>
> Hm that really looks worse than it did before.
It's not so bad.
I have manually mangled the patch so it sticks to the format when the
comments fit into one line, ie.
+/* Print a given ip including mask if necessary. */
@Ville: I forgot to indicate that comments that fit into one line look
like above. The format below ...
/* ... Only applies when the comment that doesn't it into one line for
* whatever reason.
*/
I hope it clarifies.
So applied, thanks for following up Ville.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-09-07 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 7:04 [PATCH] iptables: Spelling fixes Ville Skyttä
2015-09-05 21:07 ` Pablo Neira Ayuso
2015-09-06 6:22 ` Ville Skyttä
2015-09-06 7:15 ` Jan Engelhardt
2015-09-06 7:30 ` Ville Skyttä
2015-09-06 18:21 ` Jozsef Kadlecsik
2015-09-07 9:49 ` Ville Skyttä
2015-09-07 18:28 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907182847.GA16494@salvia \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).