netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: bridge: fix routing of bridge frames with call-iptables=1
Date: Mon, 14 Sep 2015 14:51:04 +0200	[thread overview]
Message-ID: <20150914125104.GB6864@salvia> (raw)
In-Reply-To: <1442220035-2225-1-git-send-email-fw@strlen.de>

On Mon, Sep 14, 2015 at 10:40:35AM +0200, Florian Westphal wrote:
> We need to (re-)init physoutdev to NULL, as its storage area is used
> to stash the ip destination to detect L3 nat.
> 
> For frames that are bridged this is no problem because the bridge
> forward hook initializes physoutdev to the real bridge port.
> 
> But in case the skb is delivered locally and then routed we can crash
> in the physdev match since nf_bridge->physoutdev is garbage
> (ipv4/ipv6 address)

Also applied, thanks

  reply	other threads:[~2015-09-14 12:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  8:40 [PATCH nf] netfilter: bridge: fix routing of bridge frames with call-iptables=1 Florian Westphal
2015-09-14 12:51 ` Pablo Neira Ayuso [this message]
2015-09-14 21:38   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914125104.GB6864@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).