From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, linux@eikelenboom.it
Subject: Re: [PATCH nf v2] netfilter: bridge: fix routing of bridge frames with call-iptables=1
Date: Wed, 16 Sep 2015 16:57:03 +0200 [thread overview]
Message-ID: <20150916145703.GA15642@salvia> (raw)
In-Reply-To: <1442243187-19855-1-git-send-email-fw@strlen.de>
On Mon, Sep 14, 2015 at 05:06:27PM +0200, Florian Westphal wrote:
> We can't re-use the physoutdev storage area.
>
> 1. When using NFQUEUE in PREROUTING, we attempt to bump a bogus
> refcnt since nf_bridge->physoutdev is garbage (ipv4/ipv6 address)
>
> 2. for same reason, we crash in physdev match in FORWARD or later if
> skb is routed instead of bridged.
>
> This increases nf_bridge_info to 40 bytes, but we have no other choice.
Applied, thanks.
prev parent reply other threads:[~2015-09-16 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 15:06 [PATCH nf v2] netfilter: bridge: fix routing of bridge frames with call-iptables=1 Florian Westphal
2015-09-14 19:03 ` Sander Eikelenboom
2015-09-16 14:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916145703.GA15642@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=linux@eikelenboom.it \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).