From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH next 02/84] ipvs: Don't use current in
 proc_do_defense_mode
Date: Thu, 24 Sep 2015 10:38:03 +0900
Message-ID: <20150924013800.GA4495@verge.net.au>
References: <8737y7irc8.fsf_-_@x220.int.ebiederm.org>
 <1442858581-15869-2-git-send-email-ebiederm@xmission.com>
 <20150923010648.GC17817@verge.net.au>
 <87oagtc351.fsf@x220.int.ebiederm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	David Miller <davem@davemloft.net>,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	lvs-devel@vger.kernel.org, Julian Anastasov <ja@ssi.bg>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Return-path: <lvs-devel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <87oagtc351.fsf@x220.int.ebiederm.org>
Sender: lvs-devel-owner@vger.kernel.org
List-Id: netfilter-devel.vger.kernel.org

On Tue, Sep 22, 2015 at 08:53:30PM -0500, Eric W. Biederman wrote:
> Simon Horman <horms@verge.net.au> writes:
> 
> > On Mon, Sep 21, 2015 at 01:01:39PM -0500, Eric W. Biederman wrote:
> >> Instead store ipvs in extra2 so that proc_do_defense_mode can easily
> >> find the ipvs that it's value is associated with.
> >> 
> >> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> >
> > I am wondering if this fix should be included in v4.3 and stable.
> > Can the problem occur in practice?
> 
> I believe a lookup in one network namespace followed by write in another
> network namespace would do it.  So I think it would take so pretty
> deliberate and more or less peculiar actions to make it happen.
> 
> I don't know how important the update_defense_level call is or how bad
> it is if it does not run in a network namespace .

Thanks, my feeling is that this problem can be fixed via next.