netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: kbuild-all@01.org, netfilter-devel@vger.kernel.org,
	chamas@h4.dion.ne.jp, chamaken@gmail.com
Subject: Re: [PATCH nf-next v2 2/2] netfilter: rename nfnetlink_queue_core.c to nfnetlink_queue.c
Date: Thu, 1 Oct 2015 20:07:45 +0800	[thread overview]
Message-ID: <201510012017.vqRsWNtm%fengguang.wu@intel.com> (raw)
In-Reply-To: <1443700959-32673-2-git-send-email-pablo@netfilter.org>

[-- Attachment #1: Type: text/plain, Size: 4319 bytes --]

Hi Pablo,

[auto build test results on next-20151001 -- if it's inappropriate base, please ignore]

config: m68k-sun3_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 31ae4524f70d7992a3f918bab674e2fe8588edfa
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/netfilter/nfnetlink_queue.c: In function '__nfqnl_enqueue_packet':
>> net/netfilter/nfnetlink_queue.c:518:18: warning: 'nfq_ct' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (ct && nfq_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
                     ^
   net/netfilter/nfnetlink_queue.c:316:22: note: 'nfq_ct' was declared here
     struct nfq_ct_hook *nfq_ct;
                         ^

vim +/nfq_ct +518 net/netfilter/nfnetlink_queue.c

7af4cc3f net/netfilter/nfnetlink_queue.c      Harald Welte      2005-08-09  502  		struct nfqnl_msg_packet_timestamp ts;
b7aa0bf7 net/netfilter/nfnetlink_queue.c      Eric Dumazet      2007-04-19  503  		struct timeval tv = ktime_to_timeval(entskb->tstamp);
b7aa0bf7 net/netfilter/nfnetlink_queue.c      Eric Dumazet      2007-04-19  504  		ts.sec = cpu_to_be64(tv.tv_sec);
b7aa0bf7 net/netfilter/nfnetlink_queue.c      Eric Dumazet      2007-04-19  505  		ts.usec = cpu_to_be64(tv.tv_usec);
7af4cc3f net/netfilter/nfnetlink_queue.c      Harald Welte      2005-08-09  506  
a447189e net/netfilter/nfnetlink_queue.c      David S. Miller   2012-03-29  507  		if (nla_put(skb, NFQA_TIMESTAMP, sizeof(ts), &ts))
a447189e net/netfilter/nfnetlink_queue.c      David S. Miller   2012-03-29  508  			goto nla_put_failure;
7af4cc3f net/netfilter/nfnetlink_queue.c      Harald Welte      2005-08-09  509  	}
7af4cc3f net/netfilter/nfnetlink_queue.c      Harald Welte      2005-08-09  510  
08c0cad6 net/netfilter/nfnetlink_queue_core.c Valentina Giusti  2013-12-20  511  	if ((queue->flags & NFQA_CFG_F_UID_GID) && entskb->sk &&
08c0cad6 net/netfilter/nfnetlink_queue_core.c Valentina Giusti  2013-12-20  512  	    nfqnl_put_sk_uidgid(skb, entskb->sk) < 0)
08c0cad6 net/netfilter/nfnetlink_queue_core.c Valentina Giusti  2013-12-20  513  		goto nla_put_failure;
08c0cad6 net/netfilter/nfnetlink_queue_core.c Valentina Giusti  2013-12-20  514  
ef493bd9 net/netfilter/nfnetlink_queue_core.c Roman Kubiak      2015-06-12  515  	if (seclen && nla_put(skb, NFQA_SECCTX, seclen, secdata))
ef493bd9 net/netfilter/nfnetlink_queue_core.c Roman Kubiak      2015-06-12  516  		goto nla_put_failure;
ef493bd9 net/netfilter/nfnetlink_queue_core.c Roman Kubiak      2015-06-12  517  
d343eb79 net/netfilter/nfnetlink_queue_core.c Pablo Neira Ayuso 2015-10-01 @518  	if (ct && nfq_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
ae08ce00 net/netfilter/nfnetlink_queue_core.c Eric Dumazet      2013-03-17  519  		goto nla_put_failure;
ae08ce00 net/netfilter/nfnetlink_queue_core.c Eric Dumazet      2013-03-17  520  
7f87712c net/netfilter/nfnetlink_queue_core.c Florian Westphal  2013-06-04  521  	if (cap_len > data_len &&
7f87712c net/netfilter/nfnetlink_queue_core.c Florian Westphal  2013-06-04  522  	    nla_put_be32(skb, NFQA_CAP_LEN, htonl(cap_len)))
ae08ce00 net/netfilter/nfnetlink_queue_core.c Eric Dumazet      2013-03-17  523  		goto nla_put_failure;
ae08ce00 net/netfilter/nfnetlink_queue_core.c Eric Dumazet      2013-03-17  524  
496e4ae7 net/netfilter/nfnetlink_queue_core.c Florian Westphal  2013-06-29  525  	if (nfqnl_put_packet_info(skb, entskb, csum_verify))
7237190d net/netfilter/nfnetlink_queue_core.c Florian Westphal  2013-04-19  526  		goto nla_put_failure;

:::::: The code at line 518 was first introduced by commit
:::::: d343eb794f25c72b22631ffc19be0d15fc7f607c netfilter: nfnetlink_queue: get rid of nfnetlink_queue_ct.c

:::::: TO: Pablo Neira Ayuso <pablo@netfilter.org>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 10993 bytes --]

  reply	other threads:[~2015-10-01 12:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 12:02 [PATCH nf-next v2 1/2] netfilter: nfnetlink_queue: get rid of nfnetlink_queue_ct.c Pablo Neira Ayuso
2015-10-01 12:02 ` [PATCH nf-next v2 2/2] netfilter: rename nfnetlink_queue_core.c to nfnetlink_queue.c Pablo Neira Ayuso
2015-10-01 12:07   ` kbuild test robot [this message]
2015-10-01 12:22     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201510012017.vqRsWNtm%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=chamaken@gmail.com \
    --cc=chamas@h4.dion.ne.jp \
    --cc=kbuild-all@01.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).