From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ian Morris <ipm@chirality.org.uk>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: Line layout whitespace fixes
Date: Fri, 2 Oct 2015 13:19:02 +0200 [thread overview]
Message-ID: <20151002111902.GA29902@salvia> (raw)
In-Reply-To: <560DC543.3060809@chirality.org.uk>
On Fri, Oct 02, 2015 at 12:44:03AM +0100, Ian Morris wrote:
>
> On 30/09/15 23:17, Pablo Neira Ayuso wrote:
> >On Thu, Sep 24, 2015 at 11:10:06AM +0100, Ian Morris wrote:
> >>Fixes various whitespace issues detected by checkpatch (e.g. adding spaces between operations, replacing spaces with tabs, etc)
> >>
> >>No changes detected by objdiff.
> >These large cleanup patch causes problems for -stable maintainers,
> >since they have more conflicts when backporting stuff.
> >
> >I'd rather keep this back.
> >
> Please help me understand: until when do you propose such changes be
> deferred? Or are you suggesting we should apply changes more incrementally
> somehow?
Regarding your suggestion to apply changes more incrementally, I think
that's a good idea since that will help us evaluate if there are
better things we can do to improve that code.
So please go send small batches with incremental way that we can
review. Depending on the change, some of them may trigger the rework
of existing code, others probably will just get in as is.
Thanks.
prev parent reply other threads:[~2015-10-02 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 10:10 [PATCH nf-next] netfilter: Line layout whitespace fixes Ian Morris
2015-09-30 22:17 ` Pablo Neira Ayuso
2015-10-01 23:44 ` Ian Morris
2015-10-02 11:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002111902.GA29902@salvia \
--to=pablo@netfilter.org \
--cc=ipm@chirality.org.uk \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).