From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Neutron Soutmun <neo.neutron@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] libmnl: Drop the EXPORT_SYMBOL() tags
Date: Mon, 5 Oct 2015 17:39:25 +0200 [thread overview]
Message-ID: <20151005153925.GA22976@salvia> (raw)
In-Reply-To: <20151002013240.GA21692@oxygen>
On Fri, Oct 02, 2015 at 08:32:40AM +0700, Neutron Soutmun wrote:
> diff --git a/src/internal.h b/src/internal.h
> index 3a88d1a..1012df2 100644
> --- a/src/internal.h
> +++ b/src/internal.h
> @@ -2,11 +2,5 @@
> #define INTERNAL_H 1
>
> #include "config.h"
> -#ifdef HAVE_VISIBILITY_HIDDEN
> -# define __visible __attribute__((visibility("default")))
> -# define EXPORT_SYMBOL(x) typeof(x) (x) __visible
> -#else
> -# define EXPORT_SYMBOL
> -#endif
>
> #endif
Could you git rm src/internal.h there and resubmit?
BTW, I would *really* appreciate if you send me similar patches for
other libraries in the tree, to leave things in consistent state.
Thanks.
next prev parent reply other threads:[~2015-10-05 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 1:32 [PATCH v2] libmnl: Drop the EXPORT_SYMBOL() tags Neutron Soutmun
2015-10-05 15:39 ` Pablo Neira Ayuso [this message]
2015-10-05 17:45 ` Neutron Soutmun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005153925.GA22976@salvia \
--to=pablo@netfilter.org \
--cc=neo.neutron@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).