From: Simon Horman <horms@verge.net.au>
To: Cong Wang <cwang@twopensource.com>
Cc: Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out
Date: Wed, 7 Oct 2015 10:14:36 +0900 [thread overview]
Message-ID: <20151007011435.GA22578@verge.net.au> (raw)
In-Reply-To: <CAHA+R7MezkwDg0mTMrR2HZ3sc7OMG2J-ED9F3g4XL7_16QBYyw@mail.gmail.com>
On Tue, Oct 06, 2015 at 04:27:35PM -0700, Cong Wang wrote:
> On Tue, Oct 6, 2015 at 11:24 AM, Julian Anastasov <ja@ssi.bg> wrote:
> >
> > Hello,
> >
> > On Tue, 6 Oct 2015, Simon Horman wrote:
> >
> >> Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and
> >> ip_vs_in_icmp_v6") the net variable in ip_vs_out() appears to be unused
> >> unless CONFIG_IP_VS_IPV6 is set. To resolve this remove the net variable
> >> and dereference net asneeded.
> >>
> >> Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > Both patches look good to me
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
>
> David sent a same patch earlier:
>
> http://www.spinics.net/lists/netdev/msg345887.html
Thanks, I have queued up his version in ipvs-next.
prev parent reply other threads:[~2015-10-07 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 8:15 [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out Simon Horman
2015-10-06 18:24 ` Julian Anastasov
2015-10-06 23:27 ` Cong Wang
2015-10-07 1:14 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007011435.GA22578@verge.net.au \
--to=horms@verge.net.au \
--cc=cwang@twopensource.com \
--cc=ebiederm@xmission.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).