From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] netfilter: nfqueue: don't use prev pointer
Date: Tue, 13 Oct 2015 12:04:24 +0200 [thread overview]
Message-ID: <20151013100424.GA1986@salvia> (raw)
In-Reply-To: <1444389037-17285-1-git-send-email-fw@strlen.de>
On Fri, Oct 09, 2015 at 01:10:37PM +0200, Florian Westphal wrote:
> Usage of -prev seems buggy. While packet was out our hook cannot be
> removed but we have no way to know if the previous one is still valid.
>
> So better not use ->prev at all. Since NF_REPEAT just asks to invoke
> same hook function again, just do so, and continue with nf_interate
> if we get an ACCEPT verdict.
>
> A side effect of this change is that if nf_reinject(NF_REPEAT) causes
> another REPEAT we will now drop the skb instead of a kernel loop.
>
> However, NF_REPEAT loops would be a bug so this should not happen anyway.
Good catch. Applied, thanks Florian.
prev parent reply other threads:[~2015-10-13 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 11:10 [PATCH -next] netfilter: nfqueue: don't use prev pointer Florian Westphal
2015-10-13 10:04 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013100424.GA1986@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).