From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] chain: fix segfault in 'device' XML parsing
Date: Tue, 13 Oct 2015 12:07:04 +0200 [thread overview]
Message-ID: <20151013100704.GA2261@salvia> (raw)
In-Reply-To: <20151013073910.19469.65757.stgit@r2d2.cica.es>
On Tue, Oct 13, 2015 at 09:39:10AM +0200, Arturo Borrero Gonzalez wrote:
> Reported by valgrind:
> [...]
> ==14065== Process terminating with default action of signal 11 (SIGSEGV)
> ==14065== Access not within mapped region at address 0x0
> ==14065== at 0x4C2C022: strlen (vg_replace_strmem.c:454)
> ==14065== by 0x4E41A93: nftnl_chain_set_str (chain.c:259)
> ==14065== by 0x4E427F7: nftnl_mxml_chain_parse (chain.c:770)
> ==14065== by 0x4E48F96: nftnl_ruleset_parse_chains (ruleset.c:314)
> ==14065== by 0x4E4959A: nftnl_ruleset_xml_parse_ruleset (ruleset.c:625)
> ==14065== by 0x4E4959A: nftnl_ruleset_xml_parse_cmd (ruleset.c:668)
> ==14065== by 0x4E4959A: nftnl_ruleset_xml_parse (ruleset.c:706)
> ==14065== by 0x4E4959A: nftnl_ruleset_do_parse (ruleset.c:734)
> ==14065== by 0x4013C9: test_xml (nft-parsing-test.c:166)
> ==14065== by 0x4016F4: execute_test (nft-parsing-test.c:214)
> ==14065== by 0x400EBA: main (nft-parsing-test.c:330)
> [...]
>
> While at it, fix a bit the coding style.
Applied, thanks Arturo.
prev parent reply other threads:[~2015-10-13 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 7:39 [libnftnl PATCH] chain: fix segfault in 'device' XML parsing Arturo Borrero Gonzalez
2015-10-13 9:40 ` Arturo Borrero Gonzalez
2015-10-13 10:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013100704.GA2261@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).