From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH nft] src: add interface wildcard matching
Date: Sun, 18 Oct 2015 22:18:49 +0200 [thread overview]
Message-ID: <20151018201849.GC4386@breakpoint.cc> (raw)
In-Reply-To: <20151018201427.GA9765@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Oct 18, 2015 at 08:33:13PM +0200, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > Contrary to iptables, we use '*' as wildcard as in udev since the '+' can be
> > > used as a valid interface name.
> >
> > '*' can also be part of an interface name, seems only '/', ':', and ' '
> > (space) are disallowed.
>
> We can allow escaping the asterisk:
>
> # nft --debug=netlink add rule test test iifname eth\\*
> ip test test
> [ meta load iifname => reg 1 ]
> [ cmp eq reg 1 0x5c687465 0x0000002a 0x00000000 0x00000000 ]
>
> This means, exact matching for those outthere using wildcards in
> device name, see patch attached.
Right, nice. I agree that * is a better choice than +.
> This applies on top of this initial patch.
After re-reading Patricks suggestion I'm withdrawing my question wrt.
binop-and. Patch looks good to me, thanks Pablo!
prev parent reply other threads:[~2015-10-18 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 18:02 [PATCH nft] src: add interface wildcard matching Pablo Neira Ayuso
2015-10-18 18:33 ` Florian Westphal
2015-10-18 19:04 ` Patrick McHardy
2015-10-18 19:43 ` Florian Westphal
2015-10-18 20:39 ` Patrick McHardy
2015-10-18 20:14 ` Pablo Neira Ayuso
2015-10-18 20:18 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018201849.GC4386@breakpoint.cc \
--to=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).