From: Florian Westphal <fw@strlen.de>
To: Joe Stringer <joestringer@nicira.com>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org,
Linux Netdev List <netdev@vger.kernel.org>,
Andy Zhou <azhou@nicira.com>
Subject: Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb
Date: Tue, 20 Oct 2015 22:46:58 +0200 [thread overview]
Message-ID: <20151020204657.GJ4386@breakpoint.cc> (raw)
In-Reply-To: <CANr6G5zgPbVeagJUePm9+e_fxSBu5Kr9iYM_k+Eh672h0Pa9kQ@mail.gmail.com>
Joe Stringer <joestringer@nicira.com> wrote:
> This hunk looks very similar to the logic in ip_frag_reasm(). Did you
> consider refactoring to share it?
Could be done but I did not plan to do that.
next prev parent reply other threads:[~2015-10-20 20:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 20:14 [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 1/4] netfilter: ipv6: remove extra clone/free operations Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 2/4] inet: kill obsolete skb_free op Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb Florian Westphal
2015-10-20 18:39 ` Joe Stringer
2015-10-20 20:46 ` Florian Westphal [this message]
2015-10-17 20:14 ` [PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion Florian Westphal
2015-10-20 6:25 ` Joe Stringer
2015-10-20 8:18 ` Florian Westphal
2015-10-20 6:16 ` [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag Joe Stringer
2015-10-20 8:17 ` Florian Westphal
2015-10-20 18:43 ` Joe Stringer
2015-10-20 20:53 ` Florian Westphal
2015-10-20 23:59 ` Joe Stringer
2015-10-21 12:42 ` Pablo Neira Ayuso
2015-10-21 14:50 ` Florian Westphal
2015-10-21 16:52 ` Joe Stringer
2015-10-21 14:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020204657.GJ4386@breakpoint.cc \
--to=fw@strlen.de \
--cc=azhou@nicira.com \
--cc=joestringer@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).