From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb Date: Tue, 20 Oct 2015 22:46:58 +0200 Message-ID: <20151020204657.GJ4386@breakpoint.cc> References: <1445112865-31523-1-git-send-email-fw@strlen.de> <1445112865-31523-4-git-send-email-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netfilter-devel@vger.kernel.org, Linux Netdev List , Andy Zhou To: Joe Stringer Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:38012 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbbJTUrA (ORCPT ); Tue, 20 Oct 2015 16:47:00 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Joe Stringer wrote: > This hunk looks very similar to the logic in ip_frag_reasm(). Did you > consider refactoring to share it? Could be done but I did not plan to do that.