From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jarno Rajahalme <jrajahalme@nicira.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH 4/5] openvswitch: conntrack netlink API updates.
Date: Wed, 21 Oct 2015 12:41:33 +0200 [thread overview]
Message-ID: <20151021104133.GA2135@salvia> (raw)
In-Reply-To: <1445379629-112880-4-git-send-email-jrajahalme@nicira.com>
On Tue, Oct 20, 2015 at 03:20:28PM -0700, Jarno Rajahalme wrote:
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index 77850f1..1e6c2ac 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -291,7 +291,7 @@ size_t ovs_key_attr_size(void)
> + nla_total_size(4) /* OVS_KEY_ATTR_SKB_MARK */
> + nla_total_size(4) /* OVS_KEY_ATTR_DP_HASH */
> + nla_total_size(4) /* OVS_KEY_ATTR_RECIRC_ID */
> - + nla_total_size(1) /* OVS_KEY_ATTR_CT_STATE */
> + + nla_total_size(4) /* OVS_KEY_ATTR_CT_STATE */
> + nla_total_size(2) /* OVS_KEY_ATTR_CT_ZONE */
> + nla_total_size(4) /* OVS_KEY_ATTR_CT_MARK */
> + nla_total_size(16) /* OVS_KEY_ATTR_CT_LABEL */
This is very strange.
You're changing the size of the netlink attribute, this will break
existing userspace applications.
next prev parent reply other threads:[~2015-10-21 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445379629-112880-1-git-send-email-jrajahalme@nicira.com>
2015-10-21 8:33 ` [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition Thomas Graf
[not found] ` <20151021083323.GB15539-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>
2015-10-21 20:15 ` Jarno Rajahalme
2015-10-21 23:32 ` [ovs-dev] " Thomas Graf
[not found] ` <1445379629-112880-4-git-send-email-jrajahalme@nicira.com>
2015-10-21 10:41 ` Pablo Neira Ayuso [this message]
2015-10-21 11:18 ` [RFC PATCH 4/5] openvswitch: conntrack netlink API updates Thomas Graf
[not found] ` <1445379629-112880-3-git-send-email-jrajahalme@nicira.com>
[not found] ` <1445379629-112880-3-git-send-email-jrajahalme-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2015-10-21 10:44 ` [RFC PATCH 3/5] netfilter: Allow calling into nat helper without skb_dst Pablo Neira Ayuso
2015-10-21 20:44 ` Jarno Rajahalme
[not found] ` <1445379629-112880-2-git-send-email-jrajahalme@nicira.com>
[not found] ` <1445379629-112880-2-git-send-email-jrajahalme-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2015-10-21 8:50 ` [RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info() Thomas Graf
2015-10-21 10:45 ` Pablo Neira Ayuso
2015-10-21 20:43 ` Jarno Rajahalme
2015-10-21 21:38 ` Jarno Rajahalme
[not found] ` <1445379629-112880-5-git-send-email-jrajahalme@nicira.com>
2015-10-21 10:59 ` [RFC PATCH 5/5] openvswitch: Interface with NAT Thomas Graf
2015-10-21 21:04 ` Jarno Rajahalme
2015-10-21 23:30 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021104133.GA2135@salvia \
--to=pablo@netfilter.org \
--cc=dev@openvswitch.org \
--cc=jrajahalme@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).