From: Thomas Graf <tgraf@suug.ch>
To: Jarno Rajahalme <jrajahalme@nicira.com>
Cc: netdev <netdev@vger.kernel.org>,
dev@openvswitch.org, netfilter-devel@vger.kernel.org
Subject: Re: [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.
Date: Thu, 22 Oct 2015 01:32:11 +0200 [thread overview]
Message-ID: <20151021233211.GF23554@pox.localdomain> (raw)
In-Reply-To: <B6033DCD-F46E-4416-9844-CF663215559A@nicira.com>
On 10/21/15 at 01:15pm, Jarno Rajahalme wrote:
>
> > On Oct 21, 2015, at 1:33 AM, Thomas Graf <tgraf@suug.ch> wrote:
> > I understand what you are doing here but this is part of the published
> > UAPI and removing this might break compilation of a user application
> > even if the definition is not used right now. It's probably safer to
> > leave the definition and obsolete it with a comment.
>
> OK. I should probably separate the netlink and openvswitch changes to separate patches as well?
Given that at that point the changes become unrelated, I'd split
it into separate patches, yes.
next prev parent reply other threads:[~2015-10-21 23:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445379629-112880-1-git-send-email-jrajahalme@nicira.com>
2015-10-21 8:33 ` [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition Thomas Graf
[not found] ` <20151021083323.GB15539-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>
2015-10-21 20:15 ` Jarno Rajahalme
2015-10-21 23:32 ` Thomas Graf [this message]
[not found] ` <1445379629-112880-4-git-send-email-jrajahalme@nicira.com>
2015-10-21 10:41 ` [RFC PATCH 4/5] openvswitch: conntrack netlink API updates Pablo Neira Ayuso
2015-10-21 11:18 ` Thomas Graf
[not found] ` <1445379629-112880-3-git-send-email-jrajahalme@nicira.com>
[not found] ` <1445379629-112880-3-git-send-email-jrajahalme-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2015-10-21 10:44 ` [RFC PATCH 3/5] netfilter: Allow calling into nat helper without skb_dst Pablo Neira Ayuso
2015-10-21 20:44 ` Jarno Rajahalme
[not found] ` <1445379629-112880-2-git-send-email-jrajahalme@nicira.com>
[not found] ` <1445379629-112880-2-git-send-email-jrajahalme-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2015-10-21 8:50 ` [RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info() Thomas Graf
2015-10-21 10:45 ` Pablo Neira Ayuso
2015-10-21 20:43 ` Jarno Rajahalme
2015-10-21 21:38 ` Jarno Rajahalme
[not found] ` <1445379629-112880-5-git-send-email-jrajahalme@nicira.com>
2015-10-21 10:59 ` [RFC PATCH 5/5] openvswitch: Interface with NAT Thomas Graf
2015-10-21 21:04 ` Jarno Rajahalme
2015-10-21 23:30 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021233211.GF23554@pox.localdomain \
--to=tgraf@suug.ch \
--cc=dev@openvswitch.org \
--cc=jrajahalme@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).