netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Neal P. Murphy" <neal.p.murphy@alum.wpi.edu>
To: netfilter-devel@vger.kernel.org
Cc: Ani Sinha <ani@arista.com>
Subject: Re: linux 3.4.43 : kernel crash at __nf_conntrack_confirm
Date: Thu, 22 Oct 2015 03:42:32 -0400	[thread overview]
Message-ID: <20151022034232.58e5af7a@playground> (raw)
In-Reply-To: <CAOxq_8PLX_+w-7mfx1Agh+utogEiFWHSmEFd0Bax1LY6qbEN-w@mail.gmail.com>

On Wed, 21 Oct 2015 14:26:35 -0700
Ani Sinha <ani@arista.com> wrote:

> On Wed, Oct 21, 2015 at 2:19 PM, Florian Westphal <fw@strlen.de> wrote:
> > Ani Sinha <ani@arista.com> wrote:
> >> >> > commit c6825c0976fa7893692e0e43b09740b419b23c09
> >> >> > Author: Andrey Vagin <avagin@openvz.org>
> >> >> > Date:   Wed Jan 29 19:34:14 2014 +0100
> >> >> >      netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get
> >> >> >
> >> >> > and a followup patch :
> >> >> >
> >> >> > commit e53376bef2cd97d3e3f61fdc677fb8da7d03d0da
> >> >> > Author: Pablo Neira Ayuso <pablo@netfilter.org>
> >> >> > Date:   Mon Feb 3 20:01:53 2014 +0100
> >> >> >         netfilter: nf_conntrack: don't release a conntrack with non-zero refcnt
> >> >> >
> >> >
> >> > These for instance fix such bugs.
> >>
> >> So since both these patches were not backported to 3.4 series and
> >> since now we have evidence of a crash that points to issues which the
> >> patches fix, should we consider backporting the above patches to 3.4?
> >
> > Yes.
> 
> Ok cool. I will send out backport patches for 3.4 corresponding to
> both the above patches.

As an FYI, Zefan Li just released 3.4.110; I didn't see the fix in the list. No surprise, of course; it does take more than 12 hours to get patches right, as I am painfully aware.

I just bumped Smoothwall Express to 3.4.109 in Update4, and 3.4.110 contains fixes that relate to Smoothwall. May I safely assume that these patches will apply easily to 3.4.110? The obvious answer is, "Yes," but I'd like a bit of reassurance (<pat> <pat> "There, there; it'll be fine. The patches will be OK.") before I prepare and release the next update.

Neal

  reply	other threads:[~2015-10-22  7:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 19:57 linux 3.4.43 : kernel crash at __nf_conntrack_confirm Ani Sinha
2015-10-18  2:34 ` Ani Sinha
2015-10-18  8:07   ` Florian Westphal
     [not found]     ` <CAOxq_8NLLFyNCSDJ68+VjxFGpNSex8ShdhGFNBHK29g_+UBW6g@mail.gmail.com>
2015-10-18 21:12       ` Ani Sinha
2015-10-18 21:40         ` Florian Westphal
2015-10-19 20:22           ` Ani Sinha
2015-10-19 20:33             ` Florian Westphal
2015-10-19 22:13               ` Ani Sinha
2015-10-21 19:35     ` Ani Sinha
2015-10-21 21:19       ` Florian Westphal
2015-10-21 21:26         ` Ani Sinha
2015-10-22  7:42           ` Neal P. Murphy [this message]
2015-10-22 19:53             ` Ani Sinha
2015-10-23  2:39               ` Neal P. Murphy
2015-10-24 18:28                 ` Ani Sinha
2015-10-26  6:13                   ` Neal P. Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151022034232.58e5af7a@playground \
    --to=neal.p.murphy@alum.wpi.edu \
    --cc=ani@arista.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).