From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nfnetlink: don't probe module if it exists
Date: Wed, 28 Oct 2015 03:45:20 +0100 [thread overview]
Message-ID: <20151028024520.GA3254@salvia> (raw)
In-Reply-To: <1445948425-19080-1-git-send-email-fw@strlen.de>
On Tue, Oct 27, 2015 at 01:20:25PM +0100, Florian Westphal wrote:
> nfnetlink_bind request_module()s all the time as nfnetlink_get_subsys()
> shifts the argument by 8 to obtain the subsys id.
>
> So using type instead of type << 8 always returns NULL.
Applied, thanks Florian.
prev parent reply other threads:[~2015-10-28 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:20 [PATCH nf] netfilter: nfnetlink: don't probe module if it exists Florian Westphal
2015-10-28 2:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028024520.GA3254@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).