netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	Alin Nastac <alin.nastac@gmail.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ebtables: Allow RETURN target rules in user defined chains
Date: Wed, 28 Oct 2015 14:31:34 +0100	[thread overview]
Message-ID: <20151028133134.GA24571@breakpoint.cc> (raw)
In-Reply-To: <20151028024625.GA3301@salvia>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Oct 28, 2015 at 03:46:00AM +0100, Pablo Neira Ayuso wrote:
> > On Wed, Oct 28, 2015 at 02:01:55AM +0100, Florian Westphal wrote:
> > > Alin Nastac <alin.nastac@gmail.com> wrote:
> > > > ebtables has a bug that prevents creation of rules with RETURN target, any attempt will result in an
> > > >    RETURN not allowed on base chain
> > > > error even if the chain where you want to create the rule is a user defined chain.
> > > > 
> > > > Reproduction scenario:
> > > >    root@OpenWrt:~# ebtables -N foo
> > > >    root@OpenWrt:~# ebtables -A OUTPUT -j foo
> > > >    root@OpenWrt:~# ebtables -A foo -j mark --mark-or 3 --mark-target RETURN
> > > >    --mark-target RETURN not allowed on base chain.
> > > > 
> > > > My email client will probably replace tabs in the patch below, but
> > > 
> > > Yes, I applied this manually (with minor edits to commit message).
> > 
> > Thanks, I wonder since then this has been broken BTW.
> 
> s/then/when/

Seems it never worked.

I hacked 'allow checking for --xxxx--target RETURN rules on base chains'
commit from 2002 to build and it rejects RETURN unconditionally.

      reply	other threads:[~2015-10-28 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 14:41 [PATCH] ebtables: Allow RETURN target rules in user defined chains Alin Nastac
2015-10-28  1:01 ` Florian Westphal
2015-10-28  2:46   ` Pablo Neira Ayuso
2015-10-28  2:46     ` Pablo Neira Ayuso
2015-10-28 13:31       ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028133134.GA24571@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=alin.nastac@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).