* [PATCH 1/1] use vzalloc() instead of vmalloc() for counterstmp
@ 2015-10-30 12:30 Loganaden Velvindron
2015-10-30 16:22 ` Loganaden Velvindron
0 siblings, 1 reply; 2+ messages in thread
From: Loganaden Velvindron @ 2015-10-30 12:30 UTC (permalink / raw)
To: netfilter-devel
counterstmp is not cleared before it is used in get_counters(). it might be
leaked partially when it is sent to userland later on.
Signed-off-by: Loganaden Velvindron <logan@elandsys.com>
---
net/bridge/netfilter/ebtables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index f46ca41..26922e9 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -989,7 +989,7 @@ static int do_replace_finish(struct net *net, struct ebt_replace *repl,
the check on the size is done later, when we have the lock */
if (repl->num_counters) {
unsigned long size = repl->num_counters * sizeof(*counterstmp);
- counterstmp = vmalloc(size);
+ counterstmp = vzalloc(size);
if (!counterstmp)
return -ENOMEM;
}
@@ -1410,7 +1410,7 @@ static int copy_counters_to_user(struct ebt_table *t,
return -EINVAL;
}
- counterstmp = vmalloc(nentries * sizeof(*counterstmp));
+ counterstmp = vzalloc(nentries * sizeof(*counterstmp));
if (!counterstmp)
return -ENOMEM;
--
2.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] use vzalloc() instead of vmalloc() for counterstmp
2015-10-30 12:30 [PATCH 1/1] use vzalloc() instead of vmalloc() for counterstmp Loganaden Velvindron
@ 2015-10-30 16:22 ` Loganaden Velvindron
0 siblings, 0 replies; 2+ messages in thread
From: Loganaden Velvindron @ 2015-10-30 16:22 UTC (permalink / raw)
To: netfilter-devel
Please discard this one as the subject is not formatted correctly.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-30 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 12:30 [PATCH 1/1] use vzalloc() instead of vmalloc() for counterstmp Loganaden Velvindron
2015-10-30 16:22 ` Loganaden Velvindron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).